Change API for handling Errors

[Nokome Bentley]

Some suggested API changes after using logga "for real"...

Change LogInfo.stackTrace to LogInfo.stack

In this example, I wanted to catch an exception, augment its message with additional information and send the message and the stack trace to the logger:

} catch (error) {
      let {message, stack: stackTrace} = error
      message = `Processing ${file}: ${message}`
      logger.error({message, stackTrace})
}

It would require less thinking and be a little more convenient if you could do:

} catch (error) {
      let {message, stack} = error
      message = `Processing ${file}: ${message}`
      logger.error({message, stack})
}

Add Error to union type for the message parameter of logger functions

If Error was a valid type for the message parameter i.e.

warning(message: string | LogInfo | Error): void;

Then it would be possible to just pass the error to the function e.g.

} catch (error) {
      logger.error(error)
}

[Ben Shaw]

Can I suggest something like this: https://docs.python.org/2/library/logging.html#logging.Logger.exception

Which is specifically for logging exceptions. In Python it automatically gets the exception from the current context and logs with ERROR level. I'm not sure we could do that but could still pass in the error.

} catch (error) {
      logger.exception('Error when doing the thing', error)
}

This overloading of argument types doesn't seem good to me.

[Nokome Bentley]

I think that's a good suggestion. +1

…

On Mon, Jun 3, 2019, 13:26 Ben Shaw ***@***.***> wrote: Can I suggest something like this: https://docs.python.org/2/library/logging.html#logging.Logger.exception Which is specifically for logging exceptions. In Python it automatically gets the exception from the current context and logs with ERROR level. I'm not sure we could do that but could still pass in the error. } catch (error) { logger.exception('Error when doing the thing', error) } This overloading of argument types doesn't seem good to me. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=AAIZKUHOAUXKNLDBRKU4RIDPYRXKVA5CNFSM4HSDZOPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWYCT4Y#issuecomment-498084339>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIZKUDYKXNNVEXDK6RRVLTPYRXKVANCNFSM4HSDZOPA> .