Ability to chain tasks

[Alexander Schepanovski]

I tried with many task dedupe libs including yours and this doesn't work:

(task1.si(42) | task2.s(1)).delay()
(task1.si(42) | task2.s(2)).delay()

I want task1(42) to be deduped and then both task2(1) and task2(2) be ran after it finished. Is this possible?

[Steinthor Palsson]

Why doesn't this work?
I have no idea how chaining works in celery internally, so not sure what is needed here.

I'm open to PR if you're interested in implementing this.

[Alexander Schepanovski]

As far as I understand, you send a message to broker to perform first task and chain info is inside. The worker handles that. But if you don't send a message then the chain is simply lost.

[Steinthor Palsson]

So we would need some way to add tasks to this existing chain?
Is that even doable without being riddled with race conditions?

[Alexander Schepanovski]

I don't think you can edit chains and other callbacks of existing messages generally and if message was read by the worker then it's probably too late anyway.

We can however save chain info to Redis when read it when task is done and send a new message

[Luis Saavedra]

I'm checking this bug and seem to be a problem with delivery the task task1.si(42) (only one time and then "disappear"), so the second task never is ready... for example:

import time
from celery_singleton import Singleton
from somewhere import celery_app

@celery_app.task(base=Singleton)
def do_stuff(*args, **kwargs):
	time.sleep(4)
	return 'I just woke up'

# run 3 times
async_result = (do_stuff.si(1) |  do_stuff.s(2)).delay()
async_result2 = (do_stuff.si(1) |  do_stuff.s(3)).delay()

# sleep  3 times 
time.sleep(12)

assert async_result.ready() # ok
assert async_result2.ready() # fail

'I just woke up' is only printed 2 times... must be 3...

[Petr Dlouhý]

I have similar problem even without chaining - if I run the task.get() method in two simultaneous Flask requests, only one request gets finished. The other is waiting infinitly.

[Petr Dlouhý]

I think, that it might be enough to send the right message from Singleton.on_duplicate, which could even get the chain property to be passed from apply_async, but I gave up, because I was not able to find the right message to be sent.