stefanprodan / podinfo

Go microservice template for Kubernetes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

k8s recommended labels

knweiss opened this issue · comments

I have a nitpicking question regarding label best practices: What about using the k8s recommended labels AKA common labels instead of (or in addition to) the private label app?

The current configuration triggers this kubescape warning: C-0077 - K8s common labels usage

Maybe kustomize/kustomization.yaml could be extended like this:

+commonLabels:
+  app.kubernetes.io/name: "podinfo"
+  app.kubernetes.io/managed-by: "kustomize"
...

Podinfo is used by many projects for e2e testing and docs (CNCF Flux, Flagger, Linkerd, etc), changing the labels is not something I would consider as they are immutable.