Giters

stefanprodan / AspNetCoreRateLimit

ASP.NET Core rate limiting middleware

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The NuGet package doesn't mention a license

vladimir-kazakov opened this issue · comments

commented

Both AspNetCoreRateLimit and AspNetCoreRateLimit.Redis NuGet packages don't mention their licenses in the package metadata. According to the package authoring best practices, a license must be specified.

Here is an example of a package with its license properly specified: Microsoft.Extensions.Caching.StackExchangeRedis.

In the project files of both libraries I see <PackageLicense>http://opensource.org/licenses/MIT</PackageLicense>, and it seems that it's wrong, because:

  • The property name must be PackageLicenseExpression and its value is the name of a license.
  • URLs are not recommended because of legal ambiguities.

P.S. I'm using the dotnet-project-licenses tool for automatic verification of allowed licenses, so missing licenses in AspNetCoreRateLimit packages make me a bit sad.

commented

Feel free to open a PR and fix the issue