stefandrissen / SAM-MOD-player

SAM MOD player, an Amiga MOD player for the SAM Coupé

Home Page:https://www.worldofsam.org/products/sam-mod-player

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issue playing MOD: h0ffman - Way To Rude

dandoore opened this issue · comments

This MOD loads OK and starts to play but then it all goes a bit odd...
https://modarchive.org/index.php?request=view_by_moduleid&query=188875

That's h0ffman for ya... could you be a bit more specific? You do have a meg?

https://youtu.be/RhadgzDU2JE seems ok to me.

ModPlayer v2.36 Latest release, Simcoupé x64 latest build under Win11, 4Meg enabled in options - but I see from the YT link you have 2.37 so maybe related to something like this?

Also see around 2:17 on the video, position 0x20 - odd things happening with the waa-uh-uh sample.

Aha, I thought I had nothing new in 2.37 yet, but that commit is after 2.36, so I was mistaken.

I see what you mean with the waa-uh-uh sample. The sample (instrument 31) consists of two parts:

image

The issue seems to be that when a sample is played with a sample offset (9 command) a subsequent note without an instrument should retrigger at any earlier offset set.

If you look at channel 3 of pattern 10 (using OpenMPT):

F#5 31v32 ...
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
F#5 31 .. C08
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
F#5 31 .. C02
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
... .. .. ...
F#5 31 .. C01
... .. .. ...
F#5 31v32 916 <- 9 = sample offset, parameter = 16
... 31 .. 916
... .. .. ...
... .. .. ...
F#5 .. .. ... <- should also be played with offset 16
... .. .. ...
... .. .. ...
... .. .. ...
F#5 .. .. C08 <- should also be played with offset 16
... .. .. ...
... .. .. ...

This is probably an issue in more of H0ffman's mods - for example Eon generally sounds ok, but there are a few breaks that do not sound quite right.

Ah... found some reference material: The Counting Riddle (sample offset question)

Attached is the isolated offending pattern, channel and sample.

way_too_sample.zip