stefandoorn / sitemap-plugin

Sitemap Plugin for Sylius eCommerce platform

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Model setters with optional values (nullable)

stefandoorn opened this issue · comments

I think we should get rid of this kind of setter parameters:

  public function setter(?string value): void;

If such setters still exist after #92, we might make it non-nullable. Either provide a string, or not use the setter at all in the implementation layer.

See my response in #92