stefandoorn / sitemap-plugin

Sitemap Plugin for Sylius eCommerce platform

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

See which models don't need setters

stefandoorn opened this issue · comments

It might be good to move away from model setters where possible, in case the data can be provided via the constructor. It improves immutability, as long as we keep extensibility in the implementation layer.

  • Identify models / setters
  • Adjust models

I think optional attributes should be nullable. As mentioned before in the future we will probably implement an event system where users can plug in to events. These events will likely carry these objects and hence they user will be able to modify the objects as per their use case.