Additional comma on argument list breaks on PHP < 8.0
reyostallenberg opened this issue · comments
There is no PHP version requirement in composer.json therefore this line just breaks projects when installing on PHP lower than 8.0
What can we do about this? In my opinion PHP > 8.0 should be a requirement in composer
Which PHP version are you using? I'm not 100% sure, but isn't this also working on PHP 7.4?
In the declaration of a method it's allowed from PHP 8+
See https://php.watch/versions/8.0/trailing-comma-parameter-use-list
Ah.. indeed. Will see if I can push a new version without them, and another one with them but with the PHP version requirement :)
I think it's fixed now with this release: https://github.com/stefandoorn/google-tag-manager-plugin/releases/tag/v1.2.2
For me it is fixed this way, thanks