router-benchmark
alecmev opened this issue · comments
Alec Mev commented
I've added this router to router-benchmark
. Please, check, whether the implementation is reasonable, and, if you desire, add a link to the benchmark in this project's readme.
Weilin Shi commented
Fantastic job!
However, if you look around, you will see that there is another PR that add trek-router
. This trek-router
seems to be more performant than find-my-way
, at least in the benchmark. If they did not merge that one, they probably won't merge your PR. That said, I will be glad to add a link if they merge your PR.
Alec Mev commented
Yeah, I do share your reservations. Let's wait and see.
I'll close this in the meanwhile, since it isn't really an issue.
Alec Mev commented
It got merged!