stealjs / steal-tools

Build easy. Load fast.

Home Page:https://stealjs.com/docs/steal-tools.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Code stripping leaves code in bundle

DaveO-Home opened this issue · comments

commented

Code not removed, application can be found @ github.com/DaveO-Home/embedded-acceptance-tests
Upgrade steal-tools from directory public and run gulp from stealjs/build. index.js will be located @
dist/bundles/stealjs/appl/js/
You will find that testit is not stripped. The app fails because "testit" is undefined.

//!steal-remove-start
        if (testit) {
            describe("Popper Defined - required for Bootstrap", function () {

                it("is JQuery defined", function () {
                    expect(typeof $ === "function").toBe(true);
                });

                it("is Popper defined", function () {
                    expect(typeof Popper === "function").toBe(true);
                });

            });
        }
//!steal-remove-end

Are you in Windows by any chance? There's a bug fix not released yet.

commented

No, Linux - Question, can you have NODE_ENV=development and removeDevelopmentCode: true.

Yes, steal-tools doesn't use NODE_ENV unless you are using envify.

commented

Verified that 1.12.0-pre.0 fixes the problem.

Ok, I think I can do a patch release with that bug fix.

This was released in 1.11.8.

commented

1.11.8 verified - thanks