Giters

stealjs / steal-tools

Build easy. Load fast.

Home Page:https://stealjs.com/docs/steal-tools.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing stealRequire.dynamic with done-autorender

m-mujica opened this issue · comments

commented

A simple app with a main like:

<html>
	<head>
		<title>Hello page</title>
	</head>
	<body>
		<can-import from="test/basics-optimized/state" export-as="viewModel"/>
		<h1 id="hello">Hello {{hello()}}!</h1>
	</body>
</html>

Fails to load using the slim build, since done-autorender will dynamically load test/basics-optimized/state but the loader won't include the progressive loading stuff because there are not secondary bundles written out (test/basics-optimized/state is included in the main bundle)

Solution

My solution (which I'm not happy with) is to output the progressive loading pieces of the slim loader when there are secondary bundles written out OR done-autorender is in the graph.

Ideally we should be able to detect that there are dynamic imports in the codebase and extend the loader accordingly but that detection is made during transpile; unless we use a flag in a load object or something, how does steal-tools know about the dynamic loading?

Also, in the regular build if dynamic loading is used, there will be some config needed to create new bundles, done-autorender is just a strange use case in that regard.

commented

So is the problem that we need to include the progressive bits even in an app that isn't using progressive loading, because they are using can-import which calls the System.import?

If that's correct then can we have done-autorender add some configuration to the loader that tells the build the progressive stuff is needed. Add a loader.needsSlimDynamicLoader = true or something. At least then we're not special-casing this module in the build.

commented

ok, will try this instead.