Please convert every file in this to a jinja theme or similar.

[Chris Punches]

Hello,

Avoiding the apparent design issues with interpolation checks, I might suggest that you instead move to using jinja templates or similar for all files and then doing a full file replacement during application of themes,after storing the last used theme in a backup folder automatically. And then making the paths configurable in a config file for the tool itself.

This will give you much greater flexibility in each theme and will make themes almost universally applicable. I would also do away completely with any interaction with .Xresources and .extend.X*.

I'd submit a pull request doing this myself but it would be a full rewrite, and I'll need to devote that time to unkinking all my config files now to get a usable desktop again.

[Stavros Grigoriou]

Hello @cmpunches , I'd be glad to work on this if you could point me to the right direction here. Your idea seems great but there is one point that I'm not so into. The first version I even wrote did a full file replacement but I removed it because it would cause problems to some people for the simple reason that it would overwrite their keybindings/default programs etc. For personal use yeah it's great and way faster but for general use I'm not that sure.

I'll check your idea once you submit it, if it works better be sure that it will get merged.

I've wanted to rework this project but I cannot still find the time once I'm extremely busy for the past few months, so your help is always appreciated. Also thank you for your honest critique.

EDIT: I've said that many times in the past but I'll say that again, always backup your configuration files before using the script. For me it works perfectly but not for every else, so it's good to always have a backup in case your desktop breaks.

EDIT2: Forgot to mention, if you feel like rewriting the script and adding your own things just go ahead with it and let me know. If you want to contact me for anything just send me an email on [e-mail] once I check it more often that my GitHub account.

[Chris Punches]

For keybindings you could just have a separate template file included in that theme's template where the user defines their keybindings, but really they're applying a theme, this is not so important. If they want custom keybindings I think they should add them in after applying the theme. There's no general use right now as it is.

…

On Mon, Jan 22, 2018 at 7:52 AM, Stavros Grigoriou ***@***.*** > wrote: Hello @cmpunches <https://github.com/cmpunches> , I'd be glad to work on this if you could point me to the right direction here. Your idea seems great but there is one point that I'm not so into. The first version I even wrote did a full file replacement but I removed it because it would cause problems to some people for the simple reason that it would overwrite their keybindings/default programs etc. For personal use yeah it's great and way faster but for general use I'm not that sure. I'll check your idea once you submit it, if it works better be sure that it will get merged. I've wanted to rework this project but I cannot still find the time once I'm extremely busy for the past few months, so your help is always appreciated. Also thank you for your honest critique. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALmNqFlD0Ma3fXwwQi4w9wnPyKWFI08vks5tNISrgaJpZM4RmBi6> .

[Stavros Grigoriou]

Well in that case do as you wish sir, your idea is good enough for me.

[Stavros Grigoriou]

Hello sir,

The whole repository has been reworked, so I'm closing this issue for now. In case you meet any new issues then please open a new Issue thread that is more up-to-date.