QUERY PARAMETER CLOSURE
knighht opened this issue · comments
Sayid Mabrur commented
Hi staundenmeir,
I think it is a better idea if you implemented the $query
parameter with Closure
or Callable
instead of Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|string
. It's not just make the code looks tidier, it also make the code readeable especially to new programmer like me :P.
Regards,
knighht
Jonas Staudenmeir commented
I'll look into it.
Jonas Staudenmeir commented
I decided against it: For such a minor feature, it would require too much new code.