staudenmeir / laravel-migration-views

Laravel database migrations with SQL views

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

QUERY PARAMETER CLOSURE

knighht opened this issue · comments

Hi staundenmeir,

I think it is a better idea if you implemented the $query parameter with Closure or Callable instead of Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder|string. It's not just make the code looks tidier, it also make the code readeable especially to new programmer like me :P.

Regards,
knighht

I'll look into it.

I decided against it: For such a minor feature, it would require too much new code.