Is the crate/protect still maintained/alive?
Magnetuz opened this issue · comments
I noticed that the latest commit to main is from September 2022. Many old PRs and still opened.
Is this project/crate still maintained or alive?
Thanks
I saw that the owner has had effectively zero activity on GitHub in the past two years, seems like we need a fork and a maintainer if we like this enough.
His email & domain is dead too.
I could host under https://github.com/rust-random/ if need be, but have no intention of maintaining the crate myself. (The only point is that I could approve other maintainers as they step up.)
That would be nice, but perhaps this should wait until someone can actually step in as a maintainer.
While I'm willing, I have zero experience and feel really underqualified - I'm not even hired as a junior developer yet. @dhardy if you'd be alright being (or connecting me to) a mentor that's not a maintainer while I'm a maintainer, then I'll operate as a first pass filter. If you don't have that bandwidth or don't know someone who's willing to, I won't go for it.
@YeungOnion sure, I can provide some mentorship. If you're not in a hurry, lets wait at least until next week to see if anyone else has something to say.
The crate is owned by @boxtown and statsrs-dev... but I don't see anyone there (or know of hidden members).
@dhardy I think it is a good idea to fork the repo and develop it further. If @boxtown will come back we will find a way to merge all together.
Anyway a new maintainer need to fix the situation with tests. When I committed my pool request it was not clear how to run all tests. So, on my opinion, cargo test command should work before a new crate will be published on crates.io. I believe this is a minimal and fair threshold criteria for a fork.
@dhardy Me and @troublescooter are members, but I think we cannot add anyone else.
@dhardy I think it is a good idea to fork the repo and develop it further. If @boxtown will come back we will find a way to merge all together.
Anyway a new maintainer need to fix the situation with tests. When I committed my pool request it was not clear how to run all tests. So, on my opinion,
cargo testcommand should work before a new crate will be published oncrates.io. I believe this is a minimal and fair threshold criteria for a fork.
Which issue did you have, @tessob ?
I run with cargo +nightly test --features nightly and all tests run and passed, except the ones marked with ignore.
Just cargo test won't run all tests, as many are behind the nightly feature and there is no fix for this
Hey all, I'm happy to help facilitate transfer of ownership however its done. Short term, I've granted @vks ownership in statrs-dev so he should be able to manage access to the Github group. I can grant ownership for the Crate to whoever ends up as the maintainer.
Let's continue comms using this issue to track and I'll make sure to be responsive for as long as its necessary to ensure a healthy transition.
Thanks all!
I would be willing to help maintain this crate, perhaps in collaboration with @YeungOnion. I have no prior experience with maintaining but have submitted some PRs for this crate. Will be able to find help within my organisation for learning best practices etc.
Seeing this also made me fix tests in the old PRs and refresh my knowledge of the crate. Excited to see this get going again!
@henryjac and @YeungOnion I've invited both of you to the statrs-dev org as owners. I believe this should allow you to publish/yank crates as well.
If and when you feel comfortable, I can add one or both of you as named owners of the crate (and potentially remove myself).
Thanks a bunch for stepping up! I genuinely wished I had the time/drive to give this crate the attention it deserves but I'm happy to see it transition to people who are interested in the maintaining health of the project. Best of luck!
@Magnetuz thanks for posting the issue, it really took off quite well.
@boxtown thanks for checking in and helping us out with this transition, best wishes for what your journey has in store for you.
@henryjac guess we're a team now! I'll be doing some reading on what to know as a new maintainer, and I'll reach out within 48 hours.
@dhardy I deeply appreciate your offer to mentor me and if that's still on the table I'll gladly accept.
@YeungOnion give me a ping or email if you have questions; I don't keep a close eye on this repository.
While @henryjac and I want a place to discuss how we'll be functioning as maintainers, I believe the answer to the question this issue asks is yes.