Giters

statikbe / laravel-filament-chained-translation-manager

A translation manager tool for Laravel Filament, that makes use of the Laravel Chained Translator.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Check filament translation file from vendor, ignore already published vendor translation

valpuia opened this issue · comments

commented

This package is very useful and great.. Love the Idea and how it represent. But have one issue..

Before I use this package, I already publish filament translation file from vendor, later I used this package, but it override whatever I changed in published vendor translation.
Example: I changed 'Save Changes' to 'Update', but after using this it comes back to 'Save changes' again, and can update data from Translation Manager again, but it make double work..

Not sure whether this is correct.. but whatever customization i created for translation is replaced again.. the published vendor file should be respect and used if it is published (in my opinion)

commented

@valpuia Thanks for the bug report. We have investigated the issue and it indeed was a bug. We fixed it in the base package, see statikbe/laravel-chained-translator#6

Thanks, @WoutDeBoeck for the fix!

If you do a composer upgrade the new version (2.2.1) of statikbe/laravel-chained-translator should be installed with the fix.