Curly all rule

[Phillip Lanclos]

What version of this package are you using?
17.0.0

What problem do you want to solve?
Have a tighter rule around curly for better consistency.
Currently, the rule is set to "multi-line", which can still end up with code that isn't consistent or harder to read.

For example of consistency, both of these are ok and I think it's better to have a tighter rule around this.

if (foo) foo++
if (foo) {
  foo++
}

Another example if when the if statement is long, and the reader has to scan far to understand what will be done (usually this would happen with longer variables names)

if (foo != bar1 && foo != bar2 && foo != bar3 && foo != bar4 && foo != bar5 && foo != bar6 && foo != bar7) foo++

What do you think is the correct solution to this problem?
Change rule to curly: "all"

Are you willing to submit a pull request to implement this change?
Yes

[Théo LUDWIG]

I agree with this rule, it adds consistency! 👍

[Pelle Wessman]

I'm not so sure about this one. It's stricter for sure, but standard doesn't aim to be the strictest of them all as I see it and I'm not sure it actually will always improve the code quality. I like the one liners at times.

[Phillip Lanclos]

I think it can also improve readability as the reader's eyes always know where to look for the "what happens if" piece. I don't think it is just about being more strict, but improving predictability when reading other devs' code and reducing PR review time.

We can change this ourselves since we aren't using standard directly, but I thought this rule could help more teams than just ours.

[Pelle Wessman]

I think some initial checks in a function can be more readable as one liners, as it puts emphasis on the if-statements rather than the return value

const foo = (value) => {
  if (value === undefined) return 'foo';
  if (typeof value === 'string') return false;
  if (typeof value !== 'number') throw new TypeError('Wrong input');
  // ...
};

vs

const foo = (value) => {
  if (value === undefined) {
    return 'foo';
  }
  if (typeof value === 'string') {
    return false;
  }
  if (typeof value !== 'number') {
    throw new TypeError('Wrong input');
  }
  // ...
};

But when it comes to changes like this its also a matter of how breaking it would be to the wider community. We don't want to ship a breaking change without helping projects onboard that change.

[Phillip Lanclos]

I can't believe you put semicolons in there. Are you even using standard? 😝

Yeah, I can def see those situations might be a good place for them as long as the if statements are shorter.
I do wonder how much it would break the wider community and if the --fix option would handle that.

[Pelle Wessman]

@flippidippi I'm using semistandard