Giters

standard / eslint-config-standard

ESLint Config for JavaScript Standard Style

Home Page:https://standardjs.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

JSX indent rules no longer running

flippidippi opened this issue · comments

commented

What version of this package are you using?
16.0.3

What operating system, Node.js, and npm version?
Ubuntu WSL, node 16.6.2, npm 8.1.0

What happened?
We recently updated standard and found that it stopped fixing JSX indent issues. It was very helpful to have, especially for people new to React and using editors with incorrect tab settings. It seems like this change happened here #177, but feels a little heavy-handed. Most React code is JSX and not having ident settings on any of it isn't useful.

What did you expect to happen?
JSX should be listed for indent issues.

Are you willing to submit a pull request to fix this bug?
I think this may require more discussion as it seems like the latest "fix" for JSX indent issues removed all JSX indent linting instead of addressing the smaller issue. We didn't have any real issues. We were able to successfully linting ternaries like this

{t
  ? (
    <div>
      true
    </div>
  )
  : (
    <div>
      false
    </div>
  )}