standard-webhooks / standard-webhooks

The usage of python setup.py (as a command line tool) is deprecated according to this document.

standard-webhooks/.github/workflows/python-release.yml

Lines 32 to 35 in ce813cd

    
                 - name: Build sdist 
        
                   run: | 
        
                     python setup.py sdist 
        
                   working-directory: libraries/python

It would be better to use build instead. build is a simple python packaging build frontend.

pip install build~=1.0.3
pyproject-build . --sdist (not generating .whl file)

When I tested in a local environment, I confirmed that it worked without any code change. (but specifying build-system in pyproject.toml is recommended) After build is used, the python library can define package specifications declaratively in pyproject.toml according to PEP 517, and PEP 518.

How do you think? Before the contribution, I'd like to ask maintainers for the opinions.

I think it sounds reasonable, I'm a bit removed from the Python ecosystem at the moment. @zekth, got any thoughts?

Lgtm happy to review the PR

thanks :) I made a PR for this issue.

	- name: Build sdist
	run: \|
	python setup.py sdist
	working-directory: libraries/python

libraries(python): Improve python build system