stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!

Home Page:https://docs.stakater.com/reloader/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Helm install fails because of invalid chars in labels when using flux OCI Repository

consooo opened this issue · comments

Describe the bug
Tested with Reloader v1.0.188 and flux v2.3.0. When using OCI Repository and HelmRelease with chartref as described here: https://fluxcd.io/blog/2024/05/flux-v2.3.0/#enhanced-helm-oci-support
flux adds the artifact digest to the chartversion in the format <version>+<digest[0:12]>
https://fluxcd.io/flux/components/helm/helmreleases/#chart-reference

reloader seems to use this version as a label on its service account, etc. The + is an invalid char in that case so the helm install fails.

To Reproduce
Store the Reloader Helmchart in an OCI Repository, and try to deploy it using flux v2.3.0 using

apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: OCIRepository

Expected behavior
Reloader installs

Environment

  • Kubernetes/OpenShift Version: EKS 1.29
  • flux v2.3.0
  • reloader v1.0.188

Sorry, will be fixed in -> #686