[BUG] Recent CI authored auto-releases are broken!
kakkoyun opened this issue · comments
Describe the bug
0838acd
CI introduces an additional v as a prefix.
To Reproduce
helm upgrade
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Failure!
version: 1.0.85
appVersion: v1.0.85
to
version: v1.0.86
appVersion: vv1.0.86
must have been that version started getting v prefix
docs images are pushed with https://github.com/stakater/.github/blob/main/.github/workflows/push_container.yaml which add v by default
we push all images with "v" but when pushing the chart we remove the "v" from the version 🙄
In https://github.com/stakater/Reloader/actions/runs/8851628050/job/24308595322 it is not getting any new commits for some reason so it is not generating the operator tag properly
Rerunning the job to see if it is some flaky behavior of github-tag-action
So on rerun the action correctly generated a new tag:
Bumping tag v1.0.87 - New tag 1.0.88however then it failed with another push issue so rerunning again
The later failure could be related to #636
The last bump 9a9fee2 went as expected so I will troubleshoot a little more to see under what circumstances we get the v prefix
Thanks for looking into this ❤️
Yes it's something with the doc workflow that is causing the v prefix to appear d4b7d38
This should be resolved now, it was most probably a race condition where two push workflows ran at the same time:
- The first push workflow created a tag, and when the second workflow was about to create a tag without the "v" the action reported "No new commits since previous tag. Skipping..." and the new tag became the current tag from the first workflow which had a "v" https://github.com/anothrNick/github-tag-action/blob/afe4b67b57b8ab0908e4767109a5342003639e2e/entrypoint.sh#L135
- This was resolved in #651
- This created a correct bump 906e622
- A subsequent doc update was made in #653
- This did not update the chart as expected https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/Chart.yaml
- A subsequent Goland update ran #573
- This bumped the chart as expected without the "v" https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/Chart.yaml