[ENHANCE]Define memory request and memory limit for reloder-reloader container
kunj-bosamia opened this issue · comments
It's a good practice to define memory request and limit for any resource which you deploy on your kubernetes cluster
Solution -> The raw manifest file for reloader provided in the readme file should have memory request and limits defined.
Reference to readme -> https://github.com/stakater/Reloader?tab=readme-ov-file#vanilla-manifests
Raw manifest file -> https://raw.githubusercontent.com/stakater/Reloader/master/deployments/kubernetes/reloader.yaml
@kunjbosamiaFalkonry feel free to open a PR for this, these vanilla manifests are created from helm template itself, so it can be overridden there https://github.com/stakater/Reloader/blob/master/.github/workflows/push.yaml#L206
@MuneebAijaz can i work on this issue ?
PR for this issue -> #692
PR is merged closing the issue.