stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!

Home Page:https://docs.stakater.com/reloader/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Reloader is not working with Knative Service

jkurek1 opened this issue · comments

Hello,
I'm trying to use reloader with Knative Service.

When I'm using default strategy, nothing is happening.
In annotations strategy, pod is indeed created, but after a while terminated, therefore old pod is still running.

image

I tried to put annotations in two places:

apiVersion: serving.knative.dev/v1
kind: Service
metadata:
  name: app
  annotations:
    secret.reloader.stakater.com/reload: application
...
spec:
  template:
    metadata:
      annotations:
        autoscaling.knative.dev/minScale: "1"
        secret.reloader.stakater.com/reload: application

Annotation is added at Deployment Definition level.

When I edit kservice manually and add any annotation, new revision is created and its working fine.
image

Am I doing something wrong or you are not supporting Knative services? If not, it would be really good to have it, especially if it is easy to implement.

At the moment Reloader doesn't support Knative resources.
We would to happy to see if someone can contribute in Reloader to support Knative resources.

This can be as a workaround solution: #486