Giters

stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!

Home Page:https://docs.stakater.com/reloader/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Auto Reload for All Resources

itaispiegel opened this issue · comments

commented

We just integrated the Reloader controller in our Kubernetes cluster.
We added the reloader.stakater.com/auto: "true" annotation to our deployments, and we expect them to be reloaded every time we update the configmaps and secrets they're using.
We thought it would be better for us to change the policy to do this by default, since at the current state we need to add this annotation to all resources, and it's repetitive. In addition, we fear a case where one of the developers forgets to add this annotation, and doesn't understand why his deployment didn't get reloaded when he changed the configmap it was using.

I'd like to discuss this feature, and if you find it useful, then I'll be glad to open a PR for this :)

commented

I think we should have it as a parameter when deploying Reloader, and keep it disabled by default.

commented

I think that can be closed now?
Though it would be good if documentation explicitly specified behaviour in case of missing annotation, otherwise the sentence about "undefined values" can lead to confusion. Though I undertstand "undefined value" is one explicitly specified as null?