Don't use `RefResolver`

Question

Don't use `RefResolver`

gadomski opened this issue a year ago · comments

As of jsonschema v4.18, RefResolver is deprecated:

DeprecationWarning: jsonschema.RefResolver is deprecated as of v4.18.0, in favor of the https://github.com/python-jsonschema/referencing library, which provides more compliant referencing behavior as well as more flexible APIs for customization. A future release will remove RefResolver. Please file a feature request (on referencing) if you are missing an API for the kind of customization you need.

This issue is to track the need to update to The New Way.

Vincent Sarago · Answer 1 · Thu Jul 13 2023 00:40:14 GMT+0800 (China Standard Time)

FYI I'm getting some errors in titiler CI with the latest jsonschema developmentseed/titiler#664 (comment)

Pete Gadomski · Answer 2 · Thu Jul 13 2023 00:49:28 GMT+0800 (China Standard Time)

Thanks for the report Vincent! I wonder if we should ceil jsonschema below v4.18 for the time being? What's your sense of how broken things are over there?

Vincent Sarago · Answer 3 · Thu Jul 13 2023 01:03:49 GMT+0800 (China Standard Time)

Yep that's what I did in #1189 😅

What's your sense of how broken things are over there?

I have no idea, it's weird that they broke something in a patch release. I'm pretty sure this was unintentional but knowing it's deprecated I feel it's safer to set an upper bound to the requirement so one they do remove it pystac should continue working

Pete Gadomski · Answer 4 · Thu Jul 13 2023 04:23:53 GMT+0800 (China Standard Time)

#1189 is released in v1.8.2.

Julia Signell · Answer 5 · Thu Sep 07 2023 22:20:02 GMT+0800 (China Standard Time)

I'm going to look into this a bit today to see if the timing is right to pick it up

Sharon Fitzpatrick · Answer 6 · Fri Sep 08 2023 05:26:12 GMT+0800 (China Standard Time)

Hi @jsignell, thank you for addressing this issue. It's blocking the resolution of #1214, which is affecting Jupyter Lab in downstream applications. We truly appreciate your efforts!