st0012 / ruby-lsp-rspec

A Ruby LSP addon for RSpec tests

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Extraneous code lenses

andyw8 opened this issue Β· comments

πŸ‘‹ Not a big deal, but when trying this on https://github.com/sds/overcommit I noticed the code lenses appear on subject, and on examples within shared_examples, which seems invalid.

Hmm are you sure it's from this addon? That's the 2 keywords that are currently not supported πŸ€”

Update after talking with Stan: The subject issue is a bug, caused by the context variable:

subject { described_class.new(config, context) }

For shared_examples, I was meaning the examples or example groups within the shared_examples, since they typically wouldn't be run directly, they would be included in another group.

I'm not sure about shared_examples because I do run them directly from time to time (mostly too lazy to figure out the specific command to run them). I'd keep this behaviour for now unless more users complaint about it.

For the context bug, it should be fixed in #18

@andyw8 I've cut a release for #18 too. Thanks for reporting πŸ‘