sshyam-gupta / react-router-prompt

A replacement component for the react-router 6 `Prompt`. Allows for more flexible dialogs.

https://codesandbox.io/s/react-router-prompt-example-react-router-6-7-y9ug7z?file=/src/App.js

browser always shows the alert before reload, if 'when' is a function

komarovalexander opened this issue a year ago · comments

Alexander Komarov commented a year ago

'when' can be the BlockerFunction, in that case condition will be always true regardless the result of 'when'

react-router-prompt/src/hooks/use-prompt.ts

Line 32 in 0cfc480

if (when) {

github-actions commented a year ago

Hey, @komarovalexander. Thank you so much for taking the time to point this out

Shyam Gupta commented a year ago

@komarovalexander Fixed in v0.5.4