Convert BS to AD

Question

Convert BS to AD

axispx opened this issue 5 years ago · comments

Hi, I'm interested in solving this issue. I've already implemented this in the current codebase, but I'll wait to create the PR until the restructuring in #35 is completed. Thanks.

Srishan · Answer 1 · Tue Dec 31 2019 13:11:57 GMT+0800 (China Standard Time)

Hi, thanks for taking this!

I am hesitant about landing #35 because it breaks some downstream projects and I might even close it. It's been in limbo for a while now and I've been slacking off 😞

I would recommend that you create your PR off of the current head instead of waiting for #35.

Ashish Acharya · Answer 2 · Tue Dec 31 2019 13:18:53 GMT+0800 (China Standard Time)

Sure I can do that. I wanted to wait for #35 because it seems to have better structure overall and some kludgy parts of the code could be weeded out. Thanks.

Srishan · Answer 3 · Tue Dec 31 2019 15:08:44 GMT+0800 (China Standard Time)

Fully agree but having downstream projects is what's stopping that from landing. The project's goals have changed from its genesis so there is a lot of weeding out that needs to happen.

To me, the best way forward seems to be to create a v2/ library with the niceties in #35. But for this issue, I'd be grateful if you just went with whatever is present.

Ashish Acharya · Answer 4 · Thu Jan 02 2020 03:36:01 GMT+0800 (China Standard Time)

Closing since #41 is merged.