[RFC] Visual Studio Code theme
gagbo opened this issue · comments
Hello,
I am trying to make a theme heavily inspired by Srcery for vscode.
When I looked for srcery on the marketplace I found only one other theme, which did not move since 7 months, and did not extensively cover all the keys for color definitions in the .json file
This is why I started my own colorscheme repo, using a colorscheme that already felt complete enough for me (a Sourcerer port) and swapping a few colors from the .Xresources definitions
I'd really like your input at least about the screenshots I put in the README, and if you want to put a vscode colorscheme in this repo it would be nice too.
Even if you don't plan to publish on the marketplace, you can simply provide the .json file and if the user drops it in his extensions/themes folder it will be picked up
Hi, I think this looks good. If you're interested in maintaining it I wouldn't mind adding it to the srcery-colors org. Its up to you but good job nevertheless, I think it follows the spirit of Srcery :)
I will definitely try to maintain it, I really like dark warm colorschemes :) I suppose PRs for colorschemes do not come too often so I can overview this !
Created srcery-vscode repo and made you a collaborator. Welcome to the team :)
If you want srcery-vscode to still do it's own thing, maybe add a note concerning that in the read me. Srcery-emacs doesn't match srcery-vim exactly either, when I made it some different choices was made and now I'm kinda stuck with it cause I got used to it. I do try to match as much as possible though but the vim version is sort of the gold standard :)
I'll update all those things when I'm done with creating an Azure DevOps for srcery-colors and somehow sorting out the permissions to make the theme look more "official" in the Marketplace :)
Sounds good :)
Welcome 🎉
The extension is up on the marketplace.
I'll modify the README and stuff there as time goes on, I'm on the busy side these days.
Having the extension up on the store means I had to create a srcery-colors organization I'm still very new at this stuff, so I can try to add you to the group, but can't guarantee it will work. It's not a pressing matter at the moment anyway.
Great work. Update at your own pace, no worries. Don't worry about the market place org, I'll leave that to you.