Giters

square / workflow-kotlin

A Swift and Kotlin library for making composable state machines, and UIs driven by those state machines.

Home Page:https://square.github.io/workflow

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove JMH Benchmarks

steve-the-edwards opened this issue · comments

commented

Was used for pure-Java benchmarks of some core runtime functions to ensure they weren't getting out of hand.
We are not validating against their results in CI though (and not in the practice of running them locally to check).

They caused headaches for KMP migration, and now possibly Kotlin 1.8 migration.

They were introduced prior to androidx.microbenchmark. While having the pure JVM benchmark is nice, androidx.microbenchmark is more amenable to our toolchain and getting the validation in the context of Android is likely more useful anyway.

Follow up work would be to reproduce something similar with microbenchmark on android targets and run that in CI.