square / maker

Maker Design System by Square

Home Page:https://square.github.io/maker/styleguide/latest-stable/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Image components are attaching sourceset properties in the wrong order

mattmewton opened this issue · comments

Bug description

Right now in Maker, the src property in the Image.vue component precedes the srcset and sizes property. In order to take full advantage of sourceset, the order of properties needs to be as follows.

srcset
sizes
src

The expected property order can be viewed in the responsive images guide on MDN.

Reproduction

Viewed the Image.vue code here to observe

Environment

This affects all environments

Addressed by

No response

Can you contribute a fix?

  • I’m interested in opening a pull request for this issue.

thank for filing this issue! a PR has been opened with the fix here: #458