square / maker

Maker Design System by Square

Home Page:https://square.github.io/maker/styleguide/latest-stable/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Active Colour in Choice Should Match Primary Button Colour

tatems opened this issue · comments

Bug description

Currently, the themed selected colour in the Choice component is either black or white. It should match the primary button colour for the theme.

Reproduction

  • Have a theme that has a non-monochromatic primary colour
  • Make a selection
  • See the selected colour is #000 or #FFF instead of the primary colour

Environment

System:
    OS: macOS 12.4
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 127.35 MB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 12.18.2 - ~/.nvm/versions/node/v12.18.2/bin/node
    npm: 6.14.5 - ~/.nvm/versions/node/v12.18.2/bin/npm
  npmPackages:
    vue: ^2.6.14 => 2.6.14 
    webpack: ^5.48.0 => 5.48.0

Addressed by

No response

Can you contribute a fix?

  • I’m interested in opening a pull request for this issue.