square / maker

Maker Design System by Square

Home Page:https://square.github.io/maker/styleguide/latest-stable/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Disabled Prop in MChoice does not disable MChoiceOptions

tatems opened this issue Β· comments

Bug description

When setting the :disabled prop for MChoice to true, MChoiceOptions that live inside the default slot are not disabled. Easiest solution is to provide disabled state via the controlState provider.

Reproduction

Codesandbox Reproduction: https://codesandbox.io/s/m-choice-disabled-mnfzi3?file=/src/App.vue

Environment

System:
    OS: macOS 12.2.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 602.55 MB / 64.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 12.18.2 - ~/.nvm/versions/node/v12.18.2/bin/node
    npm: 6.14.5 - ~/.nvm/versions/node/v12.18.2/bin/npm
  npmPackages:
    vue: ^2.6.14 => 2.6.14 
    webpack: ^5.48.0 => 5.48.0


### Addressed by

_No response_

### Can you contribute a fix?

- [X] I’m interested in opening a pull request for this issue.

πŸŽ‰ This issue has been resolved in version 9.3.2 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

πŸŽ‰ This issue has been resolved in version 10.0.0-beta.6 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€