square / keywhiz

A system for distributing and managing secrets

Home Page:https://square.github.io/keywhiz/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Investigate if SecretDAO.deleteSecretsByName should also delete the contents of all the secrets.

alokmenghrajani opened this issue · comments

deleteSecretByNameAndVersion calls into SecretContentDAO. Should SecretDAO.deleteSecretsByName do the same?

Also, can we leverage cascading deletes in the database to simplify the code?