Giters

square / Valet

Valet lets you securely store data in the iOS, tvOS, watchOS, or macOS Keychain without knowing a thing about how the Keychain works. It’s easy. We promise.

Repository from Github https://github.comsquare/ValetRepository from Github https://github.comsquare/Valet

LegacyValet build errors using SPM in Xcode 11

msaps opened this issue · comments

commented

When building Valet using SPM in Xcode 11, the project fails to build for watchOS and tvOS. It looks as though LegacyValet doesn't build properly on the platforms, and this is specified as a target to build in the Package.swift. This is reproducible in the xcodeproj by attempting to build the LegacyValet project on both watchOS and tvOS.

watchOS:
Screenshot 2019-09-21 at 20 28 23

tvOS:
Screenshot 2019-09-21 at 20 28 32

commented

Thank you for the report! You're absolutely right that LegacyValet isn't built for watchOS or tvOS. I'm surprised that LegacyValet is being built as part of the Valet product, since it isn't listed as a target of the Valet product:

    products: [
        .library(
            name: "Valet",
            targets: ["Valet"]),
    ],

Looking into this now. May need to remove LegacyValet from the Package entirely. That target is only used in an integration test by the manually managed Xcode project to ensure backwards compatibility, so it shouldn't be problematic to remove it. It was never intended to be part of the built Valet product.

commented

@msaps 3.2.7 should work for you!

commented

@dfed works great - thanks a lot!! 🚀