sqlectron / sqlectron-core

Home Page:https://sqlectron.github.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

PostgreSQL SSL Support

ckee83 opened this issue · comments

Following up on the sqlectron-gui issue to add SSL mode, I found I was still unable to connect to my Heroku psql db.

sqlectron-ssl

Note that error states SSL is off, despite state of "SSL Mode" switch. Digging into the code, I found the problem was with sqlectron-core. While MySQL and SQLServer both adopt ssl settings from server.config, PostgreSQL does not.

I am submitting a pull request with the fix, and while I have built sqlectron-gui and tested that it does in fact work, I did not write specs as there were none for the already implemented mysql and sqlserver ssl support.

Good catch. Thanks @ckee83 👏 👏 👏