sql-bi / Bravo

Bravo for Power BI

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

-1 Substitution Day Doesn't Work for Christmas 2022

mattsmac opened this issue · comments

Describe the problem

When adding Christmas Eve to the US holidays for 2022 and setting both Christmas Eve and Christmas Day to -1 substitution type, I expected Christmas Day Observed to fall on 12/26/2022 and Christmas Eve Observed to fall on 12/23/2022 since Christmas Eve fell on a Saturday and Christmas Day fell on a Sunday. Instead Christmas day is still 12/25 (a Sunday), although Christmas Eve was moved appropriately.

Bravo version

1.0.1 (1.0.8381.30060)

Tabular model

Power BI Desktop, import mode

Power BI

Power BI Desktop version October 2022

Steps to reproduce the behavior

In the HolidaysDefinition table, add/update these two lines.

{ "US", 12, 24, 0, 0, 0, "Christmas Eve", -1, 100, 0, 0 },
{ "US", 12, 25, 0, 0, 0, "Christmas Day", -1, 100, 0, 0 },

Create a table in PowerBI and show all dates and holiday names. Filter to not include blank holiday names, and limit to just 2022 dates.

Additional context

No response

Screenshots

image

Anything else ?

No response

FYI I just updated to the latest build of PowerBI Desktop (Version: 2.112.1161.0 64-bit (December 2022)) and the issue still happens.

We have identified the issue, and the fix is available in version 1.0.8