sps / metrics-opentsdb

OpenTSDB Metrics Reporter

Repository from Github https://github.comsps/metrics-opentsdbRepository from Github https://github.comsps/metrics-opentsdb

Maven central version is behind github

mxk1235 opened this issue · comments

commented

I was using this package from maven central (1.0.2), and i noticed that meter metrics are not being reported. The java sources actually showed that for some reason meters are skipped in report() function, while timers, gauges, histograms, and counters are handled correctly.

@Override
public void report(SortedMap<String, Gauge> gauges, SortedMap<String, Counter> counters, SortedMap<String, Histogram> histograms, SortedMap<String, Meter> meters, SortedMap<String, Timer> timers) {

    final long timestamp = clock.getTime() / 1000;

    final Set<OpenTsdbMetric> metrics = new HashSet<OpenTsdbMetric>();

    for (Map.Entry<String, Gauge> g : gauges.entrySet()) {
        metrics.add(buildGauge(g.getKey(), g.getValue(), timestamp));
    }

    for (Map.Entry<String, Counter> entry : counters.entrySet()) {
        metrics.add(buildCounter(entry.getKey(), entry.getValue(), timestamp));
    }

    for (Map.Entry<String, Histogram> entry : histograms.entrySet()) {
        metrics.addAll(buildHistograms(entry.getKey(), entry.getValue(), timestamp));
    }

    for (Map.Entry<String, Timer> entry : timers.entrySet()) {
        metrics.addAll(buildTimers(entry.getKey(), entry.getValue(), timestamp));
    }

    opentsdb.send(metrics);
}

however, in the github repo, meters appear to be handled correctly. https://github.com/sps/metrics-opentsdb/blob/master/src/main/java/com/github/sps/metrics/OpenTsdbReporter.java#L225

i also noticed that the github repo has v1.1.1 tag, but it's not present on MVN.

Could you please refresh the published artifact?

thanks! i look forward to using it.

Looking forward to the latest version on maven central.

I'll get this sorted it out in the next day or so.

thanks~~