TerminalUI full screen off on windows
jvalkeal opened this issue · comments
Running catalog app on windows terminals misses menubar. As seen from screenshot it looks like it's off vertically by one line.
![catalog-wrong-draw](https://private-user-images.githubusercontent.com/50398/322186817-27c22562-9e16-4895-86ca-5107cc8b6f1a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg1NDIzMTAsIm5iZiI6MTcxODU0MjAxMCwicGF0aCI6Ii81MDM5OC8zMjIxODY4MTctMjdjMjI1NjItOWUxNi00ODk1LTg2Y2EtNTEwN2NjOGI2ZjFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE2VDEyNDY1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMxNDAxNzg3MTYzZDA2MTQ0ZWU3ZDI3YzE1YjQ0ZGYyODc2OWNmMDQ1ZmE1NmU1ZTM3MjYyZjVhYjRlZGVhYzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.8La0q4xR7isxFfos3JiXY_h-TjSCf3OjkKxdA5bTtqQ)
Notice empty line at bottom. Logs shows that everything is drawn in correct positions so issue may be somewhere within jline's windows related terminal classes. Almost feels like one extra line is always drawn thus moving everything up one line thus menubar goes off screen.
This is same on cmd and powershell. Using jna vs. jansi doesn't make difference.
Looks like this boils down to:
If I modify that particular section so that last row will not write that extra space and backspace things on a screen will look normal. This section looks to be executed on windows but not sure on what terminals will also get there.
As short term we could fork jline's Display class and experiment fix and then try to contribute back to jline.