spring-projects / spring-batch-extensions

Spring Batch Extensions

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove JXL support

mdeinum opened this issue · comments

since JExcelAPI is an abandoned project (no release since 2009, with serious bugs remaining).

This way we could simplify the API and remove some of the abstraction and make it dedicated for POI. We could then also consider creating an ItemWriter for writing out excel files instead of only reading.

I can pick this up during the weekend and provide a pull - if you have not started this already.

Feel free to create a pull request.

Do you think its a good idea if we first merge pull #14 so that i wipe off the unnecessary tests too?

I'm afraid I don't have write access here so I cannot merge it. @mminella would have to be the one to merge that.

Hello @mdeinum, @mminella. I have removed the JXL support. It wont allow me to create a pull as theres one pending already. You can find the changes here:

master...codelirium:master

Let me know if you need something changed.

Since you've made the changes on the same branch, both changes are currently in the same PR. Can you please break these updates into two separate branches?

Absolutely, will do so soon.

That's the ideaI've already followed with my own project and here is my implementation of a writer :https://github.com/almex/Raildelays/blob/master/batch/src/main/java/org/springframework/batch/item/file/ExcelSheetItemWriter.java

JXL Support removed in #65.