Giters

spring-guides / tut-rest

Building REST services with Spring :: Learn how to easily build RESTful services with Spring

Home Page:https://spring.io/guides/tutorials/rest/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Logging of preloading data has changed

mlvandijk opened this issue · comments

commented

Expected result (from current tutorial):
...
2018-08-09 11:36:26.169 INFO 74611 --- [main] payroll.LoadDatabase : Preloading Employee(id=1, name=Bilbo Baggins, role=burglar)
2018-08-09 11:36:26.174 INFO 74611 --- [main] payroll.LoadDatabase : Preloading Employee(id=2, name=Frodo Baggins, role=thief)
...

Actual result:
...
2022-11-22 08:56:49.491 INFO 55526 --- [ main] com.maritvandijk.payroll.LoadDatabase : Preloading Employee{id=1, name='Bilbo Baggins', role='burglar'}
2022-11-22 08:56:49.492 INFO 55526 --- [ main] com.maritvandijk.payroll.LoadDatabase : Preloading Employee{id=2, name='Frodo Baggins', role='thief'}
...

This may have changed in newer Spring version?

Please let me know if you'd like a PR to update this.

commented

Hi @mlvandijk. Thanks for the issue. If I am comparing the output correctly, ignoring the differences in date, time, and package names, the difference is adding a single quote to the string values in the field name and role. So
{id=1, name=Bilbo Baggins, role=burglar}
should become:
{id=1, name='Bilbo Baggins', role='burglar'}

A PR would be welcome to fix the output example in the README.adoc. I will mark this issue as good for first time contributors as it is a documentation change of a couple characters. Please feel free to submit a PR. Thanks again for raising the issue.