spring-guides / gs-rest-service-cors

Enabling Cross Origin Requests for a RESTful Web Service :: Learn how to create a RESTful web service with Spring that support Cross-Origin Resource Sharing (CORS).

Home Page:https://spring.io/guides/gs/rest-service-cors/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

greeting method in GreetingController is missing @ResponseBody annotation.

Nico769 opened this issue · comments

The guide mentions @ResponseBody (README.adoc, line 219) but the annotation is both missing in the GreetingController listing and the accompanying example code.

I'd be happy to make a PR :).

Thank you.

Please do make a PR for it. Thanks.

You don't need a @ResponseBody in a @RestController. So better to fix the README text IMO.

You don't need a @ResponseBody in a @RestController. So better to fix the README text IMO.

Thanks for the clarification (I'm still learning Spring in tandem with Spring Boot :)).

Please do make a PR for it. Thanks.

Great! You're welcome.