spring-cloud / spring-cloud-dataflow-acceptance-tests

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Reuse the ITs tests as ATs

tzolov opened this issue · comments

Reuse the SCDF ATs platform provisioning scripts but replace the outdated ATs test code by reusing the SDCF ITs tests.

The existing SCDF ATs test code is outdated, not based on the SCDF Stream/Task DSLs. Most importantly the ATs represents only subset of test coverage compared to the SDCF ITs. Also at the moment we need to maintain tests with overlapping coverage in two separate codebases (e.g. ITs and ATs) and using different coding models and utilities.

Given that the SDCF ITs tests use the SCDF rest clients (same as the ATs) they can be run against any platform provisioned by the ATs scripts.

For some tests, such as the Schedulers tests, that can only be run agains CF or K8s platforms only, evaluate the right codebase to maintain then. Still those tests should be written with the help of the Stream/Task DSL and the same test utilities used for the ITs.

Tasks on the Data Flow ITs side

  • Generate ITs separate jar
  • harden the test utilities so they can run agains the supported platforms (CF, K8s, Local)
  • Align the IT test sets to ensure that they cover everything provided by the existing ATs test code.
    Dependes on spring-cloud/spring-cloud-dataflow#4400

Tasks on the Data Flow ATs side

  • Remove the outdated ATs test code and use the tests from the ITs test jar instead.
  • Evaluate the best place to keep tests that runs only on CF or K8s platforms (such as Scheduler)
  • Improve the platform provisioning scripting to allow bulk apps registration during the creation phase
  • deprecate/remove the local platform ATs as they are supersede by the ITs local tests.

This is now complete.