spotify / ruler

Gradle plugin which helps you analyze the size of your Android apps.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Allow partial match for ownership identifier

leinardi opened this issue · comments

Feature description

It would be really convenient to be able to use a partial match of the identifier inside the ownership.yaml.

For example, I would expect this ownership.yaml:

- identifier: :modules:core
  owner: core

- identifier: :modules:feature
  owner: feature

- identifier: androidx
  owner: androidx

- identifier: com.google
  owner: google

to match all the dependencies that start with the group androidx to the owner androidx like, for example androidx.compose.ui:ui and androidx.core:core, and all the module that start with :modules:core to the owner core:
image

Reasoning

Keeping track of all the AndroidX and Google library would require too much effort and would be prone to error. It would be way better to be able to a partial matching to quickly group together these kind of libraries.
It would be also nice to use a similar logic for the gradle modules.

That seems like a nice feature to add. We'd probably want to use some kind of wildcard to make it explicit that this identifier should match multiple components (e.g. androidx.*), but otherwise I don't see any reason why we wouldn't want to add this.

Should be included in the 1.1.0 release.

Wow that was fast!

And it works like a charm!

image

Great to hear!