wait should ignore excluded Kinds
harsimranmaan opened this issue · comments
Harsimran Singh Maan commented
qbec apply
waits for resources to be ready. It should not wait for ignored Kinds to be ready.
-K should be respected when waiting for resources.
qbec version: 0.13.1
jsonnet version: v0.17.0
client-go version: kubernetes-1.17.13
go version: 1.15.5
commit: 4eb019139514b6306d77a40e2008ed8eab54ee97
qbec diff also shows the ignored Kind
Krishnan Anantheswaran commented
I can't reproduce this locally:
$ qbec init foo
$ cd foo
$ cat <<'EOF' >components/foo.jsonnet
{
apiVersion: "foo.com/v1",
kind: "Foo",
metadata: {
name: "xxx"
},
data: {}
}
EOF
$ qbec apply --yes default -K Foo
setting cluster to ...
setting context to ...
cluster metadata load took 874ms
1 components evaluated in 1ms
[warn] 0 of 1 matches for kind filter, check for typos and abbreviations
1 components evaluated in 0s
[warn] unable to get metadata for foo.com/v1, Kind=Foo, continue
waiting for deletion list to be returned
server objects load took 771ms
---
stats: {}
waiting for readiness of 0 objects
✓ 0s: rollout complete
command took 1.66s
Krishnan Anantheswaran commented
OTOH
$ qbec apply --yes default
setting cluster to ...
setting context to ...
cluster metadata load took 412ms
1 components evaluated in 1ms
will synchronize 1 object(s)
1 components evaluated in 0s
[warn] unable to get metadata for foo.com/v1, Kind=Foo, continue
waiting for type foo.com/v1, Kind=Foo to be available for up to 2m0s
...
Krishnan Anantheswaran commented
I don't think this is an issue. Reopen if needed.