splitrb / split

:chart_with_upwards_trend: The Rack Based A/B testing framework

Home Page:https://rubygems.org/gems/split

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Configure db_failover_allow_parameter_override not working

Manbearpixel opened this issue · comments

commented

Describe the bug
While the documentation states that it is possible to override an testing group, there seems to be an additional configuration param db_failover_allow_parameter_override which is looked at to test if an override should be used in the case of an error being thrown during the ab_test method call: https://github.com/splitrb/split/blob/master/lib/split/helper.rb#L26

In this scenario an alternative is established based on the override if this config flag returns true and the override has been passed as a parameter.

I've tried manually configuring this to return true but upon running, it seems to still see this flag as false which makes me think it is not being overwritten when the config is setup for Split:

Split.configure do |config|
  ...
  config.db_failover_allow_parameter_override = true

But when running on the application and checking the value of Split.configuration.db_failover_allow_parameter_override I get false. There is also no mention of this config flag on the main README either.

commented

Seemed like my configuration was off, db_failover_allow_parameter_override is now getting set properly! Still would plan on adding this to the documentation for future reference.