Giters

splitgraph / seafowl

Analytical database for data-driven Web applications 🪶

Home Page:https://seafowl.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Vanilla S3 object store doesn't support `copy_if_not_exists`

gruuya opened this issue · comments

commented

This is needed by delta-rs when committing changes to the table via the default implementation of ObjectStore::rename_if_not_exists, and will consequently result in Object Store error: Operation not yet implemented. atm.

Since we don't expect a great write frequency it is ok to override the ObjectStore::rename_if_not_exists with ObjectStore::rename for now (which is unsafe in principle), and down the line look into using delta-rs specific S3 store which has support for dynamo DB lock to achieve the rename atomically.