TypeError: 'undefined' is not an object (evaluating 'calls[name].push') with Coffeescript 1.7

[Víctor Martínez]

https://github.com/spine/spine/blob/dev/src/spine.coffee#L9

Operator precedence changed in Coffeescript 1.7 and calls is evaluated to false instead of {}

[Nicolas Goy]

    calls = @hasOwnProperty('_callbacks') and @_callbacks or= {}

is now compiled to:

     calls = this.hasOwnProperty('_callbacks') && (this._callbacks || (this._callbacks = {}));

instead of:

     calls = this.hasOwnProperty('_callbacks') && this._callbacks || (this._callbacks = {});

[Aaron Eischeid]

so, just this

calls = @hasOwnProperty('_callbacks') and (@_callbacks or= {})

should fix?

[Nicolas Goy]

No, that's actually the new coffee script behaviour, you want this:

calls = (@hasOwnProperty('_callbacks') and @_callbacks) or @_callbacks= {}

[Aaron Eischeid]

i see, thanks. will try to get that patched in dev soon. think there is a couple other issues with coffeescript 1.7 that also need addressed.

[Víctor Martínez]

What's wrong with this?

calls = @_callbacks || {}

[Deleted user]

I was also going to suggest making the code more readable instead of fixing the surface level syntax problems, but wasn't sure if the hasOwnProperty() was necessary in there. What about:

@_callbacks = {} unless @hasOwnProperty('_callbacks') and @_callbacks
calls = @_callbacks

And we could even do away with the intermediate calls and just use @_callbacks in the function...

[Aaron Eischeid]

fixed in dev