`app.import is not a function` unless `included` is defined in addon `index.js`

Question

`app.import is not a function` unless `included` is defined in addon `index.js`

opened this issue 8 years ago · comments

I was using D3v3 in an addon I am working on, and then switched to your library. I then started seeing this error when I start the addon's nodejs server:

TypeError: app.import is not a function
    at /Users/zz/development/ember-sparkles/node_modules/ember-d3-scale/node_modules/ember-cli-d3-shape/index.js:50:17

I discovered that the following minimal amount of code in my addon's index.js provides a workaround:

module.exports = {
  included: function() {
  }
  // etc
}

It would appear that this might be related to something you fixed earlier, here: ivanvanderbyl/ember-cli-d3-shape#7

Spencer P · Answer 1 · Wed Apr 20 2016 03:57:50 GMT+0800 (China Standard Time)

That's weird. I'm not quite sure what the implications are of using an addon for an addon that also depends on another addon. (This is the third layer now, right?)

Just perusing through the Ember-cli docs, it shows this — I didn't realize that included had a second argument:

module.exports = {
  name: 'ember-cli-x-button',
  included: function(app, parentAddon) {
    var target = (parentAddon || app);
    // Now you can modify the app / parentAddon.
  }
};

So, I'm not sure wether that means that the ember-d3-scale addon needs to handle this — or if ember-cli-d3-shape needs to. I can look into this later; but in the meantime, if you want to try seeing if changing the index file in ember-cli-d3-shape to use something like that instead might work?

Deleted user · Answer 2 · Wed Apr 20 2016 06:32:47 GMT+0800 (China Standard Time)

@spencer516 thanks... yeah, insert xzibit addon meme here. I tried adding that logic to the index.js for ember-cli-d3-shape, no luck, but I may have been doing something wrong. I'm not blocked by this, however - the above mentioned workaround seems to be fine for now.

Taras Mankovski · Answer 3 · Wed May 25 2016 05:48:57 GMT+0800 (China Standard Time)

@spencer516 @ivanvanderbyl we tried to figure this out but we couldn't get it to work. Would you guys mind jumping onto a call with us and try to figure this out? We can also show you what progress we made since the last time that we spoke.

Ivan Vanderbyl · Answer 4 · Tue May 31 2016 00:33:07 GMT+0800 (China Standard Time)

@taras for sure. I've just been travelling the last 2 weeks, finally back with an internet. When would you like to tee up a call? @spencer516

Taras Mankovski · Answer 5 · Tue May 31 2016 00:33:45 GMT+0800 (China Standard Time)

Spencer is coming back on Wednesday. Maybe set something up for Friday?

Ivan Vanderbyl · Answer 6 · Tue May 31 2016 00:36:18 GMT+0800 (China Standard Time)

That works for me. I'm now on CET (Berlin) time.

Taras Mankovski · Answer 7 · Tue May 31 2016 00:37:22 GMT+0800 (China Standard Time)

It'll likely need to be late in the evening for you because @spencer516 is on PST.

Ivan Vanderbyl · Answer 8 · Tue May 31 2016 00:50:12 GMT+0800 (China Standard Time)

No worries

Deleted user · Answer 9 · Wed Jun 01 2016 00:37:41 GMT+0800 (China Standard Time)

@spencer516 @ivanvanderbyl @taras I can do Friday, am pretty flexible regarding the time. Thanks everyone!

Ivan Vanderbyl · Answer 10 · Wed Jun 01 2016 18:43:42 GMT+0800 (China Standard Time)

I can do Friday evening between 5pm and 8pm CET (GMT+2). Which is 8a to 11am PST. Let me know what works.

Taras Mankovski · Answer 11 · Wed Jun 01 2016 23:29:22 GMT+0800 (China Standard Time)

Ok, let's do 9:00am PST which is 6pm for Ivan and noon for me. I'll send a meeting invite to everyone.