sparklemotion / nokogiri

Nokogiri (鋸) makes it easy and painless to work with XML and HTML from Ruby.

Home Page:https://nokogiri.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

feature: accept a context tag name to `Nokogiri::HTML5::DocumentFragment.parse`

flavorjones opened this issue · comments

Currently, the XML and HTML4 document fragment parse methods accept a context tag name, but the HTML5 class does not.

This has made implementing code like https://github.com/flavorjones/nokogiri-html5-inference a little bit more challenging. It's a useful API and we should just support it.

This would be a good first issue for someone!

Hi @flavorjones, if no one has started working on this issue, I would love to work on it.

@sharvy Ah, thank you so much for offering!

I apologize, but I already implemented this feature in #3246 (see eca68e7), but I neglected to close this issue because I referenced the wrong issue id in that PR.

This feature will be in v1.17 when it ships, hopefully at the end of July.

Are you interested in this feature specifically? Or can I point you at some other issue(s) that might be a good "first issue"?

@flavorjones thanks for the update! Happy to hear that it's already done. And yes, please show/assign me some other GF issues! I appreciate the guidance 🙏🙂