socks proxy support?

Question

socks proxy support?

MatzFan opened this issue 8 years ago · comments

I see that Mechanize doesn't currently support this from #422. Does this mean you would not consider adding this feature - even via a PR? For example, I have successfully used the simple monkey-patch in this Gist. It does add a dependency on the socksify gem, which you may not want of course.

Eric Hodel · Answer 1 · Thu Sep 22 2016 04:43:17 GMT+0800 (China Standard Time)

I don't think we want a hard dependency on the socksify gem. We could incorporate this as require 'mechanize/socks_proxy' that would raise an exception saying "install socksify" if it wasn't installed.

MatzFan · Answer 2 · Thu Sep 22 2016 04:45:26 GMT+0800 (China Standard Time)

Eminently sensible solution - would you like a PR to implement this?

weshatheleopard · Answer 3 · Thu Nov 16 2017 08:17:49 GMT+0800 (China Standard Time)

@drbrain: see #507

Mike Dalessio · Answer 4 · Thu Apr 01 2021 01:59:17 GMT+0800 (China Standard Time)

I'm open to merging this functionality treating socksify as an optional dependency. However the patch at #507 does not work with recent net-http-persistent versions (see #535). If someone wants to provide an updated patch I'll take a look.

Mike Dalessio · Answer 5 · Thu Apr 29 2021 14:34:23 GMT+0800 (China Standard Time)

Closing this issue, but I would accept a PR for this functionality if it can be made to work with recent versions of net-http-persistent.